feat: create global opencode.jsonc if no configs exist#26992
Merged
Conversation
rekram1-node
changed the title
Collaborator
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // explicitly routes config through env-provided paths or content. | ||
| if (!Flag.OPENCODE_CONFIG && !Flag.OPENCODE_CONFIG_DIR && !Flag.OPENCODE_CONFIG_CONTENT) { | ||
| const file = globalConfigFile() | ||
| if (!existsSync(file)) { |
Contributor
There was a problem hiding this comment.
Suggestion: this check only considers config.json, opencode.json, and opencode.jsonc, so a user who still has the legacy global config file will get a new opencode.jsonc stub before the legacy migration runs. That leaves both the schema stub and migrated config.json even though a global config did exist. Consider checking path.join(Global.Path.config, "config") before seeding, or moving this after the legacy migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opencode.jsoncwith the config schema when no global config exists.OPENCODE_CONFIG,OPENCODE_CONFIG_DIR, orOPENCODE_CONFIG_CONTENT.OPENCODE_CONFIG_DIRopt-out.Tests
bun test test/config/config.test.tsbun test test/config/config.test.ts -t "global jsonc|OPENCODE_CONFIG_DIR is set"Closes #4208